search

amondnet / vercel-action

This action make a deployment with github actions instead of Vercel builder.
https://vercel.com/docs/cli
MIT License
636 stars 98 forks source link

Let the Vercel CLI do the build #123

Open PaulRBerg opened 2 years ago

PaulRBerg commented 2 years ago

As per the Vercel CLI docs as of March 2022, it is no longer recommended to provide the builds field ourselves. Instead, the functions field should be used, but only when a Serverless Function is due to be deployed. For all other cases, the Vercel CLI should handle the build by itself, given that it knows what steps to run based on the project id (or at least this is what I understand by reading the docs, someone please correct me if I'm wrong).

Whatever the case, it's clear that builds and routes should not be used anymore:

Vercel CLI docs screenshot
amondnet commented 2 years ago

Yes, routes should be changed to rewrites. But we don't use vercel's build system, so we have to use builds. We don't even need to use builds.

PaulRBerg commented 2 years ago

We don't even need to use builds.

That's what I wanted to say in reply to your now striken-through text 😅 I just integrated your GitHub Action and skipped the builds field and deployments are working just fine.

Should the README be updated to remove the builds field?

amondnet commented 2 years ago

@paulrberg

That's what I wanted to say in reply to your now striken-through text 😅 I just integrated your GitHub Action and skipped the builds field and deployments are working just fine.

https://vercel.com/dashboard/usage

Because you use vercel build, you use vercel build time in addition to github actions. It also has some limitations. If your build takes a long time and you do multiple builds, you will see a lot of queues. Hobby plan does only one build at a time.

If that's okay with you, you can.

PaulRBerg commented 2 years ago

If your build takes a long time and you do multiple builds, you will see a lot of queues

yeah I'm already starting to see the queues ..