amondnet / vercel-action

This action make a deployment with github actions instead of Vercel builder.
https://vercel.com/docs/cli
MIT License
643 stars 100 forks source link

feat: allow spaces in vercel-args #237

Closed skyf0l closed 1 year ago

skyf0l commented 1 year ago

Splitting arguments and preserving the behavior of quotes will finally allow us to use spaces in vercel-args :tada:

Solve #236

Thanks for making MORE explicit the necessity to run npm run package to rebuild the package, I've wasted hours debugging this....

github-actions[bot] commented 1 year ago

Deploy preview for zeit-now-deployment-action-example-static ready!

✅ Preview https://zeit-now-deployment-action-example-static-g1k1ayscp-amond.vercel.app https://staging.static.vercel-action.amond.dev https://pr-237.static.vercel-action.amond.dev

Built with commit 2225a57493d7912a94f4c07373f8dcd915266574. This pull request is being automatically deployed with vercel-action

github-actions[bot] commented 1 year ago

Deploy preview for team-scope-test ready!

✅ Preview https://team-scope-test-i6j4ingpm-dietfriends.vercel.app

Built with commit 2225a57493d7912a94f4c07373f8dcd915266574. This pull request is being automatically deployed with vercel-action

github-actions[bot] commented 1 year ago

Deploy preview for vercel-action-example-nextjs ready!

✅ Preview https://vercel-action-example-nextjs-7jwau16cu-amond.vercel.app https://staging.nextjs.vercel-action.amond.dev https://pr-237.nextjs.vercel-action.amond.dev

Built with commit 2225a57493d7912a94f4c07373f8dcd915266574. This pull request is being automatically deployed with vercel-action

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

rpartridge commented 10 months ago

Hey @amondnet and @skyf0l , thanks for fixing this issue! Are there plans to include this in a future release? I see there hasn't been a release since January 2023 before this PR was merged. Thanks in advance

skyf0l commented 10 months ago

Thanks @rpartridge, until the release you can use a commit pin as follows in your workflow:

      - name: Deploy
        uses: amondnet/vercel-action@8433ae13f35aa62d68184a8fc369ce6b0143b0a3