search

amoose20 / indieProject

1 stars 0 forks source link

Peer Review #1 - Leischow Vang #2

Open ChampaineV opened 1 year ago

ChampaineV commented 1 year ago

Design/Code Review 1

Project: Sports betting odds application

Developer: Austin

Reviewer: Leischow

Item Considerations Comments/Suggestions
Problem Statement 1. Perhaps add links to your design documents in your README.md file?
2. Maybe consider creating an ERD design to help organize flow.		 1. Project purpose is clear and understandable.
2. Explains sports betting and betting odds
Design Documentation 1. Form design doesn't display the age form field as the User class includes a getAge() method. 1. Still in the progress of representing teams and professional leagues related to the user's selected favorites in a Java class.
2. Maybe add a date of birth form field?
3. Overall, the navigation flow is logical and easy to understand.
Data model/Database 1. Everything on the screens and problem statement/flow is represented in the model
1. If applicable to your app, maybe consider using the LocalDate object to get the user's date of birth? You can later create a method to get the user's age from the stored DOB from the LocalDate object.
2. Still in the progress of representing users' favorite teams and professional leagues as a database table.
Code 1. Proper Maven project structure is used
2. a .gitignore file for IntelliJ Java projects has been implemented
3. There is not any redundant or copy/paste code in the JSPs or classes
4. Classes are appropriately-sized (no monster classes)
Property files are used appropriately: no hard-coded values
5. Logging statements are used rather than System.out.println and printStackTrace.
6. There are appropriate unit tests/code coverage.		 1. Remember to add comments on all methods and classes.
2. Look through current comments as some of them are still authored by paula.
pawaitemadisoncollege commented 1 year ago

Hi @ChampaineV! Thank you for your review of this project. Your feedback demonstrates an eye to both identifying what is working well in the project and what might be improved in clear language. I hope you found some benefit in getting to review @amoose20 project so far.