sourcery-ai[bot] commented 2 years ago

Pull Request #316 refactored by Sourcery.

Since the original Pull Request was opened as a fork in a contributor's repository, we are unable to create a Pull Request branching from it.

To incorporate these changes, you can either:

Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to the original Pull Request
Incorporate changes via command line
```
git fetch https://github.com/amor71/LiuAlgoTrader pull/316/head
git merge --ff-only FETCH_HEAD
git push
```

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Help us improve this pull request!

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 1.56%.

Quality metrics	Before	After	Change
Complexity	6.36 ⭐	5.97 ⭐	-0.39 👍
Method Length	67.07 🙂	68.93 🙂	1.86 👎
Working memory	11.29 😞	10.76 😞	-0.53 👍
Quality	61.24% 🙂	62.80% 🙂	1.56% 👍

Other metrics	Before	After	Change
Lines	753	769	16

Changed files	Quality Before	Quality After	Quality Change
liualgotrader/enhanced_backtest.py	54.43% 🙂	54.95% 🙂	0.52% 👍
liualgotrader/strategies/base.py	79.39% ⭐	79.51% ⭐	0.12% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
liualgotrader/enhanced_backtest.py	do_strategy_result	16 🙂	267 ⛔	15 😞	31.72% 😞	Try splitting into smaller methods. Extract out complex expressions
liualgotrader/enhanced_backtest.py	backtest_day	12 🙂	195 😞	18 ⛔	36.43% 😞	Try splitting into smaller methods. Extract out complex expressions
liualgotrader/enhanced_backtest.py	backtest_time_range	4 ⭐	100 🙂	18 ⛔	54.17% 🙂	Extract out complex expressions
liualgotrader/enhanced_backtest.py	backtest_main	4 ⭐	133 😞	14 😞	54.22% 🙂	Try splitting into smaller methods. Extract out complex expressions
liualgotrader/enhanced_backtest.py	do_strategy_all	4 ⭐	142 😞	13 😞	54.61% 🙂	Try splitting into smaller methods. Extract out complex expressions