amor71 / LiuAlgoTrader

Framework for algorithmic trading
MIT License
784 stars 129 forks source link

Avoid a `ModuleNotFoundError` in `streamlit` #378

Closed TheSnoozer closed 1 year ago

TheSnoozer commented 1 year ago

Running a streamlit run ../analysis/backtester_ui.py causes a ModuleNotFoundError :

File "/LiuAlgoTrader/.venv/lib/python3.10/site-packages/streamlit-1.15.1-py3.10.egg/streamlit/runtime/scriptrunner/script_runner.py", line 564, in _run_script
    exec(code, module.__dict__)
  File "/LiuAlgoTrader/analysis/backtester_ui.py", line 15, in <module>
    from streamlit.uploaded_file_manager import UploadedFile
ModuleNotFoundError: No module named 'streamlit.uploaded_file_manager'

The location of UploadedFile was changed from streamlit.uploaded_file_manager to streamlit.runtime.uploaded_file_manager.

amor71 commented 1 year ago

@TheSnoozer thanks for the fix, just finished migration to PDM and merging this

sourcery-ai[bot] commented 1 year ago

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 46.00 ⛔ 46.00 ⛔ 0.00
Method Length 879.00 ⛔ 881.00 ⛔ 2.00 👎
Working memory 32.00 ⛔ 32.00 ⛔ 0.00
Quality 4.62% 4.62% 0.00%
Other metrics Before After Change
Lines 189 189 0
Changed files Quality Before Quality After Quality Change
analysis/backtester_ui.py 4.62% ⛔ 4.62% ⛔ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication