search

amorenoz / ovs-dbg

Scripts to help debug OVS and OVN
Apache License 2.0
23 stars 8 forks source link

docs: add tutorial for ovs-offline #50

Closed SalDaniele closed 3 years ago

SalDaniele commented 3 years ago

fixes #40 Signed-off-by: Salvatore Daniele sdaniele@redhat.com

SalDaniele commented 3 years ago

Hi Adrian,

This is completed and ready for review at your convenience.

amorenoz commented 3 years ago

I see a Todo on the PR description. Is this still WIP?

SalDaniele commented 3 years ago

Are you planning to tackle #48 ? If so, maybe it would be a good idea to do it before merging this one? or would you update the docs afterwards?

Yes, I'll submit that today and adjust the docs accordingly.

I see a Todo on the PR description. Is this still WIP?

No, I will remove that. I just need to complete 48 and address the feedback provided here.

amorenoz commented 3 years ago

We forgot to update the docs on the recently closed #58, would you mind modifying the relevant doc here?

amorenoz commented 3 years ago

otherwise lgtm

SalDaniele commented 3 years ago

Updated the ovs-offline page of the readthedocs and covered #58 in the tutorial. Anywhere else I should add it?

amorenoz commented 3 years ago

/LGTM