docker file seems to be missing from the pip version

amorenoz / ovs-dbg

Scripts to help debug OVS and OVN

Apache License 2.0

22 stars 8 forks source link

docker file seems to be missing from the pip version #68

Open lewisdenny opened 2 years ago

lewisdenny commented 2 years ago

pip venv:

❯ find | grep container
./.venv/lib/python3.9/site-packages/rich/containers.py
./.venv/lib/python3.9/site-packages/rich/__pycache__/containers.cpython-39.pyc

Using the git repo method:

❯ find | grep container
./containers
./containers/ovs-dbg
./containers/ovs-dbg/Dockerfile
./containers/ovs-dbg/start.sh
./.venv/lib/python3.9/site-packages/rich/containers.py
./.venv/lib/python3.9/site-packages/rich/__pycache__/containers.cpython-39.pyc

amorenoz commented 2 years ago

Installing a Dockerfile via pip doesn't feel right. In that case I think we should just download the container from quay.io. Do you require the Dockerfile to run the tool? I think if it's not found it should be downloaded