search

amorimjj / redoc-try-it-out

Add Try It Out option on Redoc
MIT License
29 stars 10 forks source link

fix: add test to prove redocVersion cannot be set #5

Closed jarlah closed 9 months ago

jarlah commented 9 months ago

this can also serve as a solid foundation for more tests.

This PR only adds a fix to the redocVersion not being overridable. Im not even trying to fix config.ts because I don't think its possible without refactoring a lot.

also updated all packages and fixed a typescript issue in config.ts

jarlah commented 9 months ago

@amorimjj would be jolly nice if you took a look at this, even if you're as busy everyone else.

jarlah commented 9 months ago

for anyone that is interested in using this try it out feature and override redocVersion, you can use this cdn link

https://cdn.jsdelivr.net/gh/jarlah/redoc-try-it-out@b7723f31d9e1ab8488334fc18eea635022899dfa/dist/try-it-out.min.js

my forks is only containing this PR plus the minified try it out file in dist folder.

jarlah commented 9 months ago

if the original package is discontinued, im more than happy to extend the fork to fix all the other issues as well. I have a couple of active open source projects in my belt already.

homestar9 commented 9 months ago

This is awesome. Thank you for doing that. I don't think this repo is maintained anymore, and I would very much like to see an updated fork. I'm sure many others would as well. :)

jarlah commented 9 months ago

moved my fork here btw

https://github.com/RedocCommunity/redoc-try-it-out

Latest version of js now being accessible at

https://cdn.jsdelivr.net/gh/RedocCommunity/redoc-try-it-out@main/dist/try-it-out.min.js

Dont think ill bother creating an npm package, unless someone sees the need for it.

If you want to contribute you are free to do so, @homestar9, or anyone else for that matter.

jarlah commented 9 months ago

hopefully "RedocCommunity" is not breaching any naming rules or trademarks

jarlah commented 9 months ago

@homestar9 would you like to help contributing to the new organisation as an owner ? then we are at least two people that can drive it forward. Since its an org its not tied to a username too, which I think "feels better"

homestar9 commented 9 months ago

@jarlah, thank you. Yeah, that sounds good to me. Typescript isn't a language I am an expert in by any means, but I am happy to contribute in any way(s) I can.

jarlah commented 9 months ago

@homestar9 cool cool. I feel there is too many repos out there that fall into the trap of only having 1 owner or 1 maintainer. Lets try to avoid that this time around ;) Its usable already, even if the swagger UIs try out table is awkwardly squished together. It's not meant to be in a sidebar, it's meant to use more space. Maybe it could use modal for the try out feature. Anyway lets continue in the new repo :=)

homestar9 commented 9 months ago

Agreed! Sounds like a plan. :)