search

amosavian / AMSMB2

Swift framework to connect SMB2/3 shares
GNU Lesser General Public License v2.1
256 stars 79 forks source link

SPM Support #80

Closed Yoorque closed 12 months ago

Yoorque commented 2 years ago

First of all, I would like to thank you for making this library. It is really useful and user friendly 👍 Nevertheless, distribution with the library as a submodule seem to be a little tricky. It would be great if SPM support was on it's way, since I use SPM for other libraries in my project and I'm reluctant to mix dependency managers. Do you have an estimate when the SPM support will be available?

Thanks again. Your effort is much appreciated.

beks6 commented 2 years ago

Leaving a comment for others

This project doesn't support SPM, you can import it with the git link into XCode through "Add Packages", but you will fail to build as described in issue #77

OmranK commented 1 year ago

SPM support added with #89

beks6 commented 1 year ago

I get a warning on the package

"Source files for target SMB2 should be located under /Users/user/Library/Developer/Xcode/DerivedData/AppName-{hash}/SourcePackages/checkouts/AMSMB2/libsmb2"

and an error in AMSMB2.swift

No such module 'SMB2'

when adding the package to my project

OmranK commented 1 year ago

Package manager automatically pulls the latest tag which is currently a prior commit to the one with the fix.

@amosavian can you please make a new tag/release so people can get the fixed package.

@beks6 you can fork the repo and create a tag for the latest commit and it will work in the meantime.

amosavian commented 12 months ago

Please use version 3.0.0