search

amosbastian / understat

An asynchronous Python package for https://understat.com/.
MIT License
150 stars 30 forks source link

Hotfix/specify packages versions and fix old test #20

Closed gracjans closed 2 years ago

gracjans commented 2 years ago

I wanted to contribute, but had some problems with running the tests. Newer versions of packages were not compatible, so i specified concrete versions of every package. Last update of this repository was done above 1 year ago, so i specified versions matching around this date.

It turned out that one test needs to be fixed (test_get_league_fixtures_with_options), so i also did it.

Now everything works and it's "ready to contribute". There are a lot of warnings, but I don't have time to work on it for now.

image

After this PR I will make second, with actual changes that I wanted to make

amosbastian commented 2 years ago

Thanks a lot! As you can tell I haven't been actively maintaining this package at all, so it's great to have someone like yourself come along who is willing to help out 😄 I really appreciate it!