search

amosbastian / understat

An asynchronous Python package for https://understat.com/.
MIT License
150 stars 30 forks source link

Get league table with date filters #22

Closed gracjans closed 2 years ago

gracjans commented 2 years ago

I'm creating AI-based bot to play FPL (link) and would like to use Your package to scrape some Understat data. I need to to get league table and clubs stats from specific time period, just like it can be done on Understat website (screen below). Unfortunately, this couldn't be done with this open-source package, but I implemented it for myself.

Perhaps this will be useful to others (I also think that filtering by date can be added to other functions, but for now I focused strictly on the get_league_table method).

I tried to follow all the guidelines (PEP8, implemented test, updated docs) but I'm still learning (it's my first open-source contribution) so if You have any concerns or remarks, don't hesitate to point them out. Also if You have any questions, I'm open to discussion.

image

image

amosbastian commented 2 years ago

I will review it tomorrow after work. Thanks! ❤️

gracjans commented 2 years ago

I will review it tomorrow after work. Thanks! ❤️

Ok, no problem, take your time! :)