amosbird / ldb_toolchain_gen

MIT License
66 stars 21 forks source link

LDB install directory has wrong permissions #14

Closed ujohnny closed 2 years ago

ujohnny commented 2 years ago

setup_toolchain.sh script creates temporary directory and then moves it into install location, see L24 & L35, however the default behaviour of mktemp command applies 700 permissions for the created folder. This makes the LDB install location available for a single user only (ie UID/GID of the script invoker).

I believe the proper approach should be like chmod ag+rx $dir.

amosbird commented 2 years ago

Sounds great! Would you like to submit a PR?

ujohnny commented 2 years ago

here it is #15