Closed marmata closed 1 year ago
amoscardino
commented
1 year ago Tags, new and existing, are sent to linkding when creating or updating a bookmark. This should result in the app's list of tags being refreshed, but I have noticed that this does not always happen. I will investigate more.
marmata
commented
1 year ago Thanks! Just to be clearer, the added/modified tags are not seen on both the app and linkding itself. It's like the tags are not sent (or not accepted?) by linkding.
On Thu, Apr 27, 2023 at 8:59 PM Andrew Moscardino @.***> wrote:
Tags, new and existing, are sent to linkding when creating or updating a bookmark. This should result in the app's list of tags being refreshed, but I have noticed that this does not always happen. I will investigate more.
— Reply to this email directly, view it on GitHub https://github.com/amoscardino/linkthing/issues/27#issuecomment-1526183018, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYZ2N4IW5YVUFRS656BJFLXDK62TANCNFSM6AAAAAAXNLP2DI . You are receiving this because you authored the thread.Message ID: @.***>
-- I'm Winston Wolf, I solve problems.
amoscardino
commented
1 year ago Strange. Can you send an example tag value that does this? It may be an issue with the linkding API or how the tags are formatted before they are sent.
marmata
commented
1 year ago Sure! Here's a video of me adding a new shortcut via clipboard, adding a couple of tags and then going back to check if tags are there: https://share.icloud.com/photos/0651kc5JB98Joi3ai3fHp7MBQ Not sure if I can get any logs from the server itself, but I can provide those if needed!
Cheers, ]\/[arco
On Fri, Apr 28, 2023 at 11:54 PM Andrew Moscardino @.***> wrote:
Strange. Can you send an example tag value that does this? It may be an issue with the linkding API or how the tags are formatted before they are sent.
— Reply to this email directly, view it on GitHub https://github.com/amoscardino/linkthing/issues/27#issuecomment-1528130715, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYZ2N6NMOKJGMD5XKE6PF3XDQ4BLANCNFSM6AAAAAAXNLP2DI . You are receiving this because you authored the thread.Message ID: @.***>
-- I'm Winston Wolf, I solve problems.
amoscardino
commented
1 year ago I think I have a fix for this. It appears that the tags don't persist back to the bookmark object to be saved until you move focus from the input. So having the input focused and then tapping the save button doesn't have a chance to read those changes before sending the bookmark off to the API. I'm testing this fix now but I imagine I'll have it to app review before the end of the week.
marmata
commented
1 year ago Oh I understand now! So it just moving the focus before saving should do the job! Will try it!
On Wed, May 10, 2023 at 8:32 PM Andrew Moscardino @.***> wrote:
I think I have a fix for this. It appears that the tags don't persist back to the bookmark object to be saved until you move focus from the input. So having the input focused and then tapping the save button doesn't have a chance to read those changes before sending the bookmark off to the API. I'm testing this fix now but I imagine I'll have it to app review before the end of the week.
— Reply to this email directly, view it on GitHub https://github.com/amoscardino/linkthing/issues/27#issuecomment-1542634245, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYZ2N3ZC3EHJAGCQ67FDPDXFPNKTANCNFSM6AAAAAAXNLP2DI . You are receiving this because you authored the thread.Message ID: @.***>
-- I'm Winston Wolf, I solve problems.
marmata
commented
1 year ago Awesome, thanks!
On Fri, 12 May 2023 at 13:34, Andrew Moscardino @.***> wrote:
Closed #27 https://github.com/amoscardino/linkthing/issues/27 as completed via #28 https://github.com/amoscardino/linkthing/pull/28.
— Reply to this email directly, view it on GitHub https://github.com/amoscardino/linkthing/issues/27#event-9232082752, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAYZ2N3N46RNHOPPA6UZQQLXFYN2ZANCNFSM6AAAAAAXNLP2DI . You are receiving this because you authored the thread.Message ID: @.***>
-- I'm Winston Wolf, I solve problems.
Hi! Just begin using link ding and this beautiful app, fantastic companion! After adding some bookmarks just realized that new tags are not created, is this intentional as in not implemented yet?