search

amosproj / amos2021ss02-project2-context-map

A context map for corporate data
MIT License
1 stars 0 forks source link

Filter service does not use common entity returning functions #257

Closed joluj closed 3 years ago

joluj commented 3 years ago

https://github.com/amosproj/amos-ss2021-project2-context-map/blob/b7f259cc03dda39a5dcabc654763c2e395d4201f/backend/src/filter/filter.service.ts#L89

https://github.com/amosproj/amos-ss2021-project2-context-map/blob/b7f259cc03dda39a5dcabc654763c2e395d4201f/backend/src/filter/filter.service.ts#L138

should use functions from src/config/commonFunctions.ts. This will reveal unwanted behaviour if the common functions are changed.

joluj commented 3 years ago

Done in 0c4a04b11cd4edcc5830a0f6c1bd93b4533ff5cb