search

amosproj / amos2022ws03-software-oscilloscope

MIT License
7 stars 2 forks source link

first working draft of implementation for #80 signal head #112

Closed nicolaskolbenschlag closed 1 year ago

nicolaskolbenschlag commented 1 year ago

Signed-off-by: nicolaskolbenschlag nicolas.kolbenschlag@googlemail.com

cypress[bot] commented 1 year ago


Test summary

6 • 0 • 0 • 0

Run details
Project sosci-frontend
Status Passed
Commit b3e8636fc8
Started Dec 2, 2022 7:29 AM
Ended Dec 2, 2022 7:30 AM
Duration 00:52 💡
OS Linux Ubuntu - 20.04
Browser Chrome 107

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

motschel123 commented 1 year ago

Can't retrospectively change from "Approve" to "Request changes" (afaik). This is only to indicate that tests are missing :)

As far as the changes only implement logic inside the plot, it is not quite possible to test for that in cypress, same applies for cursor feature. E.g. in your feature for line thickness you only could test the presence of the switches and not the logic displaying the thick lines.