amosproj / amos2022ws03-software-oscilloscope

MIT License
7 stars 2 forks source link

Implemented feature #62-cursor #114

Closed motschel123 closed 1 year ago

motschel123 commented 1 year ago

Implemented the cursor by injecting undefined data (not being displayed) in front of the new sample data.

image

Signed-off-by: Marcel Schöckel marcel.schoeckel@gmail.com

cypress[bot] commented 1 year ago



Test summary

8 0 0 0


Run details

Project sosci-frontend
Status Passed
Commit 8cec827b45
Started Dec 7, 2022 8:56 AM
Ended Dec 7, 2022 8:57 AM
Duration 01:10 💡
OS Linux Ubuntu - 22.04
Browser Chrome 107

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

motschel123 commented 1 year ago

If you know a way to test it please let me know. It's the same as the basic waves, we can't really test for web gl rendering or the correct data injection from inside cypress.

PhlppKrmr commented 1 year ago

In #111 we had a similar issue where we don't quite know how to test plotting functionalities. I'd suggest we open up an issue that evaluates how to test those additionally to the frontend testing issue we still have in the sprint backlog. Are you fine with that?