amosproj / amos2022ws03-software-oscilloscope

MIT License
7 stars 2 forks source link

Add preset save button #118 #147

Closed jandegen closed 1 year ago

jandegen commented 1 year ago

This PR includes the complete preset feature set. You can now create and select presets, which are stored inside the backend

image

(The dropdown list is just empty because of not running backend during the screenshot)

cypress[bot] commented 1 year ago



Test summary

30 0 0 0


Run details

Project sosci-frontend
Status Passed
Commit 4eafd0a6a1
Started Jan 17, 2023 9:31 PM
Ended Jan 17, 2023 9:33 PM
Duration 02:12 💡
OS Linux Ubuntu - 22.04
Browser Chrome 108

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

nicolaskolbenschlag commented 1 year ago

Screenshot from 2022-12-18 15-41-34

jandegen commented 1 year ago

Screenshot from 2022-12-18 15-41-34

This PR is still a draft :) So you probably checked out a work in progress.

It should be fixed now, I only need to fix the test cases

nicolaskolbenschlag commented 1 year ago

I see, sorry. I thought you already want it to be reviewd :)

jandegen commented 1 year ago

I am unable to run this branch. In docker-compose up --build an error occurs. Did not change anything in the configuration. Running the command on other branches works.

I cannot close your conversion.