amosproj / amos2022ws03-software-oscilloscope

MIT License
7 stars 2 forks source link

Feature/#171 responsive web design #179

Closed PhlppKrmr closed 1 year ago

PhlppKrmr commented 1 year ago

Let me know if the layout works as expected on your devices and of course, if you have any suggestions for improvement (both code & look) :)

cypress[bot] commented 1 year ago



Test summary

33 0 0 0


Run details

Project sosci-frontend
Status Passed
Commit 91c4e519ef
Started Jan 23, 2023 5:35 PM
Ended Jan 23, 2023 5:37 PM
Duration 02:37 💡
OS Linux Ubuntu - 22.04
Browser Chrome 109

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

PhlppKrmr commented 1 year ago

Please also lmk which button you'd prefer for the distribution (ignore the hover effect and size differences): 1) image 2) image

jandegen commented 1 year ago

Please also lmk which button you'd prefer for the distribution (ignore the hover effect and size differences): 1) image 2) image

Thumps up reaction for icon 1! Party reation for icon 2!

PhlppKrmr commented 1 year ago

The sliders are not anymore visible.

image

What broswer are you using here?

nicolaskolbenschlag commented 1 year ago

The sliders are not anymore visible. image

What broswer are you using here?

Chrome

PhlppKrmr commented 1 year ago

The sliders are not anymore visible. image

What broswer are you using here?

Chrome

Thanks, @nicolaskolbenschlag ! Really strange, I tested it in Edge, Brave, Chrome and Firefox and for me they are visible. Adapted styling once again, lmk if you now see them.

Edit: Translated comment from German to English

PhlppKrmr commented 1 year ago

Looks good. Any specific reason why you removed the "mui" prefix? I followed that pattern in other PRs.

Also I can would expect merge issues with Feature/#168 Rework UI for presets as the preset stuff changed a bit

Removed it cause we no longer use only mui (material ui) icons. Didn't want it to be confusing and inconsistent going forward. Hope I didn't break too much on your end ;)

jandegen commented 1 year ago

The sliders are not anymore visible. image

What broswer are you using here?

Chrome

Thanks, @nicolaskolbenschlag ! Really strange, I tested it in Edge, Brave, Chrome and Firefox and for me they are visible. Adapted styling once again, lmk if you now see them.

Edit: Translated comment from German to English

Mine looks fine: (Tested on Edge)

image image