amosproj / amos2024ss01-xcelerator-demo-app

a student project in cooperation with Siemens for a Demo Web Application around water tank management
MIT License
8 stars 1 forks source link

Service-like feature for FE pages of facilities to BE #82

Closed shahraz1998 closed 2 months ago

shahraz1998 commented 4 months ago

User story

  1. As a facility manager
  2. I want to see the right facilities with their information from the backend
  3. So that I can fetch and view up-to-date data regarding my facilities

Acceptance criteria

What is not inlcuded

Since this issue regards the facilities endpoint and not the timeseries endpoint it is not included to show Pump/ Environment data from the backend on the details page.

DoD general criteria

IngoSternberg commented 4 months ago

After @Persists explained us where the backend provides the data @Sabo2k and I implemented a service to fetch the data from the backend in the feat/xd-29-fetching-service branch. We will not merge this branch as we still need to figure out a good architecture to get the data in the frontend and not just have it in one service. It is still very useful to show that it works and how to get the data

IngoSternberg commented 3 months ago

It is still on the feat/xd-82 branch because the backend part is also not already on develop but it is basically done. Now the facilities we can see make more sense. Before this we actually displayed 2 cards for every facility and did not get a lot of meaningful data (only assetId and propertysetname):

Image

Now we actually see the facilities with their name and description from the backend. We still get the id and use it tho. Image

IngoSternberg commented 3 months ago

And now to the other part of this issue, which is basically #158. But it is also listed here that "the frontend of the facility details view displays data from the application's backend" and since this was the only branch where backend and frontend were ready for this stuff it should be ok. The facilities now show the actual pump data from the backend. The SIEMENS API only has meaningful values for 3 of the pumps right now tho

Playground-MSAgentPump (id: 8ccb6c1c6c464e5784410e5a1c8a8def) Image

PUMP-003 (id: bfcfbbdae35c4c9da77ef477b6612084) Image

PUMP-002 (id: ba9361db82f4411297bdd8494ecb040f) Image

IngoSternberg commented 3 months ago

Since my comments must now be confusing, I adjusted the description so only the part with the facilities and not the part about pump data is included