Thralls are buggy

[amot-dev]

Will add more to list if needed. Here's the known issues:

• [x] Thralls don't attack things the player is attacking (eg. passive mobs)
• [x] Thrallhood is not maintained between world loads (but glowing is)
• [ ] Thralls don't attack Zoglins
• [x] Zombie thralls break turtle eggs
• [x] Zombie thralls summon hostile reinforcements

Things that are expected and will not be fixed:

• Thrallhood is not maintained when turning into Drowned/Stray

[amot-dev]

Thrallhood between world loads can be a complex issue on servers, especially relating to other players. For example, if another player moves/kills the thralls, this needs to be reflected with regards to the thrall count on the owner.

Players will thus have to store the UUID of owned thralls and upon loading that NBT data, call a function that validates the thralls existence. May also want to ping the player on their location if out of render distance (to prevent other players stealing thralls permanently).

Thralls will have to store their owner's UUID, and upon loading that NBT data, call a function that re-initializes them as thralls.

[amot-dev]

Having all Thrall targeting in one goal may create issues. Splitting into multiple goals may allow finer target control.

Order of Thrall action priority:

• Clear Invalid Target
  • May be hard to implement. Should clear the target if it becomes invalid (i.e. the target becomes the thrall of a neutral player or the target player is no longer attacking / being attacked)
• Follow Player
• Defend Self
  • Want to prioritize self-survival. If the player really is that close to dying, the thrall probably won't help
• Defend Player
• Attack Player Target

Some quirks to also keep in mind:

• Thralls should be able to attack other players (currently they only attack mobs)
• Thralls should treat another player's thralls the same as that player
  • If target candidate is thrall, check their owner's attacking/attacker
• Ranged Thrall projectiles should not hurt the player (#54)
• Specific mobs will need specific goalSelector rules removed (all targetSelector goals are already removed)
  • For clarity, should have a function for each entity type
• Wolves should not attack skeleton Thralls, and they should not run away (#53)
• Will likely break with modded mobs (may be addressed at some later point)

[amot-dev]

As of now, functionality is as intended as it gets. Created #59 to cover Zoglin issues.

Currently, some behaviour is still buggy (i.e. sometimes skeleton thralls will try to raise their bows to attack fellow thralls or the player--presumably this is the case with non-skeletons but it's just not visible).

Either way, thralls are in a useable state right now, and there are other issues that address the various bugs, so I'm closing this.