search

amouiche / qnap_mtd_resize_for_bullseye

Script for resizing MTD partitions on a QNAP device in order to be able to upgrade from buster to bullseye
GNU General Public License v2.0
51 stars 11 forks source link

WIP: Support Bullseye fw_setenv #8

Closed cavokz closed 2 years ago

cavokz commented 2 years ago

Signed-off-by: Domenico Andreoli domenico.andreoli@linux.com

cavokz commented 2 years ago

Please hold on with this, I'll explain later on.

amouiche commented 2 years ago

I was planning to test it first anyway. regards, arnaud

Le 05/11/2021 à 09:14, Domenico Andreoli a écrit :

Please hold on with this, I'll explain later on.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/amouiche/qnap_mtd_resize_for_bullseye/pull/8#issuecomment-961701309, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADXHI5GVIM2MUXUJFQVSKJDUKOG5XANCNFSM5HBRTWCA. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

cavokz commented 2 years ago

The PR itself works as expected, I tested it with both Buster and Bullseye. The problem with the '=' notation is that it's not supported by pre-Buster u-boot-tools.

Therefore I think it's better to detect whether the fw_setenv is from u-boot-tools or from libubootenv-tools and then use the old-style or the new-style syntax.