search

amowry / WARBL2

WARBL2 Code and design files
https://warbl.xyz/index.html
GNU General Public License v3.0
5 stars 2 forks source link

Backward Compatibiliy in Config Tool #8

Closed MrMep closed 1 day ago

MrMep commented 3 days ago

In WARBL(1) jumpFactor 87 was associated to ED[38] which was CUSTOM_FINGERING_1. In midi.js we now have:

https://github.com/amowry/WARBL2/blob/a90325da783a1973508743a3fd4cc2dfda353250/webconfig/js/midi.js#L1211-L1221

I guess that we need to add a FW version check, otherwise CUSTOM_FINGERING_1 is never received from WARBL(1).

Or am I missing something?

gl

amowry commented 3 days ago

I think you're right-- I'll add a version check after I merge your pull request. Thanks for finding this!