Hitting "Add" on a catalog starts a global album art search

[apocalyptech]

I'm using Ampache 3.7.0, and it seems that whenever I hit "Add" on a catalog to add in new tracks, it kicks off a global album art search which scans for every album in my catalog. IMO it would make much more sense to only scan for the newly-added albums that were detected in the first step.

I've got logging on (with a debug level of 5) and I don't really see much that seems useful in the log. When I hit "Add" I first get a bunch of obvious file-search type activity like so:

2014-07-03 12:13:31 [pez] (Memory) -> 4.25 MB
2014-07-03 12:13:32 [pez] (Memory) -> 11.25 MB
2014-07-03 12:13:32 [pez] (read) -> Starting work on find_invalid_utf8.pl inside /var/audio
2014-07-03 12:13:32 [pez] (Memory) -> 11.25 MB
2014-07-03 12:13:32 [pez] (read) -> /var/audio/find_invalid_utf8.pl ignored, non-audio file or 0 bytes
2014-07-03 12:13:32 [pez] (read) -> Starting work on Punk inside /var/audio
2014-07-03 12:13:32 [pez] (Memory) -> 11.25 MB
2014-07-03 12:13:32 [pez] (Memory) -> 11.25 MB
2014-07-03 12:13:32 [pez] (Memory) -> 11.25 MB
2014-07-03 12:13:32 [pez] (read) -> Starting work on Rancid inside /var/audio/Punk
2014-07-03 12:13:32 [pez] (Memory) -> 11.25 MB
2014-07-03 12:13:32 [pez] (Memory) -> 11.25 MB
2014-07-03 12:13:32 [pez] (Memory) -> 11.25 MB
2014-07-03 12:13:32 [pez] (read) -> Starting work on Life_Wont_Wait inside /var/audio/Punk/Rancid
2014-07-03 12:13:32 [pez] (Memory) -> 11.25 MB
2014-07-03 12:13:32 [pez] (Memory) -> 11.25 MB
2014-07-03 12:13:32 [pez] (Memory) -> 11.25 MB
2014-07-03 12:13:32 [pez] (read) -> Starting work on 22-Coppers.mp3 inside /var/audio/Punk/Rancid/Life_Wont_Wait
2014-07-03 12:13:32 [pez] (Memory) -> 11.25 MB
2014-07-03 12:13:32 [pez] (read) -> Starting work on 09-Crane_Fist.mp3 inside /var/audio/Punk/Rancid/Life_Wont_Wait
2014-07-03 12:13:32 [pez] (Memory) -> 11.25 MB

... which goes on for quite awhile (as you'd imagine). Then eventually it just goes right into the album-art stage:

2014-07-03 12:14:02 [pez] (gather_art) -> Gathering art for Djangologie/USA (Disc One)
2014-07-03 12:14:02 [pez] (Art) -> Searching using:["db","folder"]
2014-07-03 12:14:02 [pez] (Art) -> Method used: gather_db
2014-07-03 12:14:02 [pez] (gather_art) -> Image less than 5 chars, not inserting
2014-07-03 12:14:02 [pez] (gather_art) -> Gathering art for Chronological (Disc 2) - The London Deccas (1938 & 1939)
2014-07-03 12:14:02 [pez] (Art) -> Searching using:["db","folder"]
2014-07-03 12:14:02 [pez] (Art) -> Method used: gather_db
2014-07-03 12:14:02 [pez] (gather_art) -> Image less than 5 chars, not inserting
2014-07-03 12:14:02 [pez] (gather_art) -> Gathering art for Chronological (Disc 1) - The First QHCF Recordings 1934-35 Featuring Stephane Grappelli
2014-07-03 12:14:02 [pez] (Art) -> Searching using:["db","folder"]
2014-07-03 12:14:02 [pez] (Art) -> Method used: gather_db
2014-07-03 12:14:02 [pez] (gather_art) -> Image less than 5 chars, not inserting
2014-07-03 12:14:02 [pez] (gather_art) -> Gathering art for Chronological (Disc 3)
2014-07-03 12:14:02 [pez] (Art) -> Searching using:["db","folder"]
2014-07-03 12:14:02 [pez] (Art) -> Method used: gather_db
2014-07-03 12:14:02 [pez] (gather_art) -> Image less than 5 chars, not inserting

And then eventually ending with some usual session-type stuff:

2014-07-03 12:14:52 [pez] (Core) -> Registered post form confirmation with SID 892509ef5361160a2640b07f07058959 and expiration 1404411292 (3600 seconds from now)
2014-07-03 12:14:52 [pez] (session) -> t9d25qgtdogqd8mbpletoba692 has been extended to Thu, 03 Jul 2014 13:14:52 -0500 extension length 3600

I could attach the whole log of the session if you want, but it's 750K when gzipped, and doesn't look like it's got any other information than the kinds of things I posted above.

[M4DM4NZ]

your pretty much getting the same error im getting from this post #304

[apocalyptech]

Nah, that sounds like a different thing. My Ampache is cataloging everything properly, it's just doing an album art search for all albums in my catalog whenever I add in new tracks. I'm not getting any read errors or the like.

[Afterster]

Ok I should have fixed it in develop branch. And indeed, much better. Thanks for the report.