Closed RobertoCarlo closed 3 years ago
This was indeed a small bug in 3.7.0 but it is now fixed in development branch since we removed iframes. So this bug aside, lets talk about your DJ feature. Just starting two players is not really mixing and I'm not sure we should do it in the regular webplayer. I never mix, doesn't mixing need a completely dedicated user interface?
Maybe this is outside the idea of Ampache goals, but -Having two independent audio channels at the same time for playing is enough for mixing. -Adding songs to a playlist that can play one song for A player and another for B sequentially, and crossfading them at, let's say, 15 seconds before they ends and connecting it to a server is enough to make a fully working internet radio. If you are minimalistic, it doesn't have to be A & B players, it could be A only doing same thing. -Adding pitch (speed control), waveform matching (representing song beats in a waveform and "matching" A & B ones by automatically modifying their speed) and the ability to record them would make it a full mixing software like any popular DJ Soft actually available: CrossDJ, AtomixMP3, etc.
I know that on Linus MPD supports crossfading of tracks. If you set up a local play module for MPD you may get the effects you desire.
Crossfading would be a wonderful option indeed (even outside the DJ scope). Adding "enhancement" to this issue just for this point. This will be another modification on jPlayer I believe. I'm afraid we will have to fork jPlayer project if we continue to add modification unmerged with the official project (https://github.com/happyworm/jPlayer/pull/185 and https://github.com/happyworm/jPlayer/pull/246 for now).
Waveform is already supported, see waveform
setting in ampache.cfg.php (requires transcoding settings too).
I'm not sure about your other requests (two players, ability to record, ...).
Agreed about crossfading, working on a playlist will have same use than dual players. Maybe an extra enhancement would be to add shoutcast dsp support, to connect ampache with an external radio server, e.g. cloudrad.io. Thanks Afterster!
I totally agree with the jPlayer crossfading but other specific DJ features won't be implemented they are too specific sorry.
Not sure it has been talked about, but a gapless playback could be a nice addition as well.
Never expected to have all this features implemented right now. Afterser, SUTJael thanks for your Ampache devotion and for being open to users comments. Will keep posting about any bug/enhancement issue in near future.
I've been looking into this today. I plan to merge happyworm/jPlayer#185 into the master/v2.8 branches as a fix. The happyworm/jPlayer#246 change will be merged into the dev branch as a new feature that will become current with jPlayer 2.9.
Did you guys encounter a problem due to me changing the repository structure? Apologies for any trouble I caused.
Thanks for the update @thepag. Don't worry about the repository structure changes ; I'm looking forward for jPlayer 2.9 now :)
I have managed to reproduce this irregular situation: If my Mac goes to sleep and return, Ampache will ask me to re-login, but the framed player will still operative. In this situacion, when i re-login, i will have two players (previously opened and newly created) at the same time, but only one will play audio. Then i wonder: Will it be possible to add two players at the same time for DJing purposes? As it is already possible to allow multiple logins with the same user, i have to assume yes. It would be a very nice feature to be added. Thanks for your "love of music".