search

ampas / CTL

The Color Transformation Language (CTL)
Other
220 stars 77 forks source link

install locations of a few files could be improved #123

Open michaeldsmith opened 1 year ago

michaeldsmith commented 1 year ago

With the CMAKE_INSTALL_PREFIX set to C:/Program Files (x86)/CTL in Windows 10, running Visual Studio with administrative privileges allows the INSTALL visual studio project to run by selecting Build on the INSTALL project. The output below shows where the files get copied on to the windows system:

Build started...
1>------ Build started: Project: build-time-make-directory, Configuration: Debug x64 ------
2>------ Build started: Project: INSTALL, Configuration: Debug x64 ------
2>-- Install configuration: "Debug"
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlAddr.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlAlign.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlErrors.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlExc.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlFunctionCall.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlInterpreter.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlLContext.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlMessage.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlModule.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlRcPtr.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlReadWriteAccess.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlSymbolTable.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlSyntaxTree.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlTokens.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlType.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlTypeStorage.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlStdType.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlVersion.h
2>-- Installing: C:/Program Files (x86)/CTL/lib/IlmCtl.lib
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlColorSpace.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlLookupTable.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlRbfInterpolator.h
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlSparseMatrix.h
2>-- Installing: C:/Program Files (x86)/CTL/lib/IlmCtlMath.lib
2>-- Installing: C:/Program Files (x86)/CTL/include/CTL/CtlSimdInterpreter.h
2>-- Installing: C:/Program Files (x86)/CTL/lib/IlmCtlSimd.lib
2>-- Installing: C:/Program Files (x86)/CTL/include/OpenEXR/ImfCtlApplyTransforms.h
2>-- Installing: C:/Program Files (x86)/CTL/lib/IlmImfCtl.lib
2>-- Installing: C:/Program Files (x86)/CTL/share/doc/CTL/CTL/CtlManual.pdf
2>-- Installing: C:/Program Files (x86)/CTL/share/doc/CTL/CTL/CtlManual.doc
2>-- Installing: C:/Program Files (x86)/CTL/bin/ctlrender.exe
2>-- Installing: C:/Program Files (x86)/CTL/share/CTL/utilities.ctl
2>-- Installing: C:/Program Files (x86)/CTL/bin/exrdpx.exe
2>-- Installing: C:/Program Files (x86)/CTL/share/CTL/transform_DPX_EXR.ctl
2>-- Installing: C:/Program Files (x86)/CTL/share/CTL/transform_EXR_DPX.ctl
2>-- Installing: C:/Program Files (x86)/CTL/bin/exr_ctl_exr.exe
2>-- Installing: C:/Program Files (x86)/CTL/share/CTL/change_saturation.ctl
========== Build: 2 succeeded, 0 failed, 13 up-to-date, 0 skipped ==========

In Ubuntu, after running make install, the install_manifest.txt file shows similar install locations:

root@4750b46f4bd5:/usr/src/CTL/build# cat install_manifest.txt 
/usr/local/include/CTL/CtlAddr.h
/usr/local/include/CTL/CtlAlign.h
/usr/local/include/CTL/CtlErrors.h
/usr/local/include/CTL/CtlExc.h
/usr/local/include/CTL/CtlFunctionCall.h
/usr/local/include/CTL/CtlInterpreter.h
/usr/local/include/CTL/CtlLContext.h
/usr/local/include/CTL/CtlMessage.h
/usr/local/include/CTL/CtlModule.h
/usr/local/include/CTL/CtlRcPtr.h
/usr/local/include/CTL/CtlReadWriteAccess.h
/usr/local/include/CTL/CtlSymbolTable.h
/usr/local/include/CTL/CtlSyntaxTree.h
/usr/local/include/CTL/CtlTokens.h
/usr/local/include/CTL/CtlType.h
/usr/local/include/CTL/CtlTypeStorage.h
/usr/local/include/CTL/CtlStdType.h
/usr/local/include/CTL/CtlVersion.h
/usr/local/lib/libIlmCtl.a
/usr/local/include/CTL/CtlColorSpace.h
/usr/local/include/CTL/CtlLookupTable.h
/usr/local/include/CTL/CtlRbfInterpolator.h
/usr/local/include/CTL/CtlSparseMatrix.h
/usr/local/lib/libIlmCtlMath.a
/usr/local/include/CTL/CtlSimdInterpreter.h
/usr/local/lib/libIlmCtlSimd.a
/usr/local/include/OpenEXR/ImfCtlApplyTransforms.h
/usr/local/lib/libIlmImfCtl.a
/usr/local/share/doc/CTL/CTL/CtlManual.pdf
/usr/local/share/doc/CTL/CTL/CtlManual.doc
/usr/local/bin/ctlrender
/usr/local/share/CTL/utilities.ctl
/usr/local/bin/exrdpx
/usr/local/share/CTL/transform_DPX_EXR.ctl
/usr/local/share/CTL/transform_EXR_DPX.ctl
/usr/local/bin/exr_ctl_exr

Everything looks good except for a few of files:

1 - ImfCtlApplyTransforms.h installs into /include/OpenEXR/

C:/Program Files (x86)/CTL/include/OpenEXR/ImfCtlApplyTransforms.h

but should probably be installed in /include/CTL/

C:/Program Files (x86)/CTL/include/CTL/ImfCtlApplyTransforms.h

although there may be some history of installing ImfCtlApplyTransforms.h into /include/OpenEXR for some reason, perhaps related to the old OpenEXR_Viewers project used this file or other CTL files. For example, OpenEXR_Viewers package mentions CTL here https://src.fedoraproject.org/rpms/OpenEXR_Viewers

2 - CtlManual.pdf and CtlManual.doc install into /share/doc/CTL/CTL/

C:/Program Files (x86)/CTL/share/doc/CTL/CTL/CtlManual.pdf
C:/Program Files (x86)/CTL/share/doc/CTL/CTL/CtlManual.doc

should probably be /share/doc/CTL/

C:/Program Files (x86)/CTL/share/doc/CTL/CtlManual.pdf
C:/Program Files (x86)/CTL/share/doc/CTL/CtlManual.doc
michaeldsmith commented 1 year ago

ImfCtlApplyTransforms.h from this CTL repo is included by the file /OpenEXR_Viewers/exrdisplay/applyCtl.cpp in Release branches 2.2 [1], 2.3 [2], 2.4 [3] and 2.5 [4] of the current OpenEXR repo

[1] https://github.com/AcademySoftwareFoundation/openexr/blob/RB-2.2/OpenEXR_Viewers/exrdisplay/applyCtl.cpp [2] https://github.com/AcademySoftwareFoundation/openexr/blob/RB-2.3/OpenEXR_Viewers/exrdisplay/applyCtl.cpp [3] https://github.com/AcademySoftwareFoundation/openexr/blob/RB-2.4/OpenEXR_Viewers/exrdisplay/applyCtl.cpp [4] https://github.com/AcademySoftwareFoundation/openexr/blob/RB-2.5/OpenEXR_Viewers/exrdisplay/applyCtl.cpp

michaeldsmith commented 1 year ago

ImfCtlApplyTransforms.h from this CTL repo is also included by the file /OpenEXR_Viewers/playexr/ctlToLut.cpp in Release branches 2.2 [1], 2.3 [2], 2.4 [3] and 2.5 [4] of the current OpenEXR repo

[1] https://github.com/AcademySoftwareFoundation/openexr/blob/RB-2.2/OpenEXR_Viewers/playexr/ctlToLut.cpp [2] https://github.com/AcademySoftwareFoundation/openexr/blob/RB-2.3/OpenEXR_Viewers/playexr/ctlToLut.cpp [3] https://github.com/AcademySoftwareFoundation/openexr/blob/RB-2.4/OpenEXR_Viewers/playexr/ctlToLut.cpp [4] https://github.com/AcademySoftwareFoundation/openexr/blob/RB-2.5/OpenEXR_Viewers/playexr/ctlToLut.cpp