search

ampas / aces-core

ACES Core Transforms
https://acescentral.com
Other
768 stars 124 forks source link

Two `compressionFuncParams` values are unused #151

Closed nick-shaw closed 3 months ago

nick-shaw commented 4 months ago

https://github.com/ampas/aces-dev/blob/0b632da885c29f1ca8e816b3995ad5fde976e9ae/lib/Lib.Academy.OutputTransform.ctl#L23

Only [0] and [3] from the array of values get used, with [3] being the 1.0 exponent for powerP. Values [1] and [2] were only ever used in non-reach mode, which is not included in the CTL.

I reality, only a single compressionThreshold value is needed (and it's purpose would be clearer from the name) if the compression curve is simplified to Reinhard.

scottdyer commented 3 months ago

Commit faf617a01a54eb553f58ccb330630c5284a122bc addresses this issue