Closed ieugen closed 2 years ago
The log message says it's coming from the logger named com.zaxxer.hikari.util.DriverDataSource
, but the config file you show sets levels for com.zaxxer.hikari.pool
and com.zaxxer.hikari.HikariConfig
, neither of which matches the util segment in the logger. Does it work if you set a level for com.zaxxer.hikari.util
or one of its parent loggers?
Hi, That is my initial configuration. I then do:
I changed the level for "com.zaxxer.hikari.util.DriverDataSource" to :info / :error in dialog.edn Ran initialize! and checked config is loaded in dialog.logger/config . Stopped and started my system. Logging line is still in the logs
I tested this and it is a bug.
set-level!
works fine, but not reloading the full file with initialize!
.
With initialize!
configuration is loaded but not applied = logging line is visible after reload.
Ah, okay - I think this might be that initialize!
needs to call reset-level-cache!
:
https://github.com/amperity/dialog/blob/3933260fec9c88068cf091aa47d6fd8999194499/src/clojure/dialog/logger.clj#L64-L66
Hi @greglook ,
I think I found a bug, related to : https://github.com/amperity/dialog/issues/23
I tried with
initialize!
and I can't seem to mask "com.zaxxer.hikari.util.DriverDataSource" . Setting the level via(dialog.logger/set-level! "com.zaxxer.hikari.util.DriverDataSource" :info)
works just fine.p.s. I tried with both dialog commit 1dda8ccdd5172113c126df2a0c5dd1ae31332127 and also my slf4j-2 branch.
I have a project that uses github.com/stuartsierra/component and hikari db pooling library.
I start the app and I see this line:
initialize!
and checked config is loaded in dialog.logger/config .Adding line to dialog.edn + reloading config does not change logging in existing repl. Repl needs to be restarted for this to work.
My deps.edn :