search

amperity / lein-monolith

Leiningen plugin for working with monorepos.
Other
214 stars 18 forks source link

Parse the kw-args with :subtree added back. #20

Closed jstokes closed 7 years ago

jstokes commented 7 years ago

This causes a the warning to be logged & command correctly changed to :upstream

aengelberg commented 7 years ago

:subtree is now equivalent to :upstream, so I would propose fully removing :subtree rather than adding back in.

greglook commented 7 years ago

We can do the :subtree removal too - will leave it up to @jstokes whether to do that here or in a new PR.

jstokes commented 7 years ago

Wasn't trying to add it back in, merely trying to get the warning correctly logged.

I'm not tied to :subtree being available or expected to work, so I'm fine just completely removing it altogether. I'll update this PR to just remove references to :subtree.

jstokes commented 7 years ago

Updated to remove :subtree