Move 'sh' redef outside of per-task threading to avoid races

amperity / lein-monolith

Leiningen plugin for working with monorepos.

Other

214 stars 18 forks source link

Move 'sh' redef outside of per-task threading to avoid races #58

Closed greglook closed 4 years ago

greglook commented 4 years ago

I don't think we've actually hit this bug yet, but the tool is currently susceptible to races between the start and end of the with-redefs block across threads. This should fix that by only rebinding the var once around the entire parallel execution.