search

amperity / lein-monolith

Leiningen plugin for working with monorepos.
Other
214 stars 18 forks source link

Update merged profile paths #83

Closed robhanlon22 closed 3 years ago

robhanlon22 commented 4 years ago

Removes monolith project paths and dependencies from the output, and ensures that profiles active in the monolith are activated in subprojects before reading and absolutizing paths.

As discussed in #75.

robhanlon22 commented 4 years ago

This is failing on CI because it relies on a change to project-with-profiles that was introduced in Leiningen 2.9.4. I'll have to re-evaluate, unless lein-monolith wants to add a minimum Leiningen version requirement.

EDIT: I modified this to be less efficient, but it's now functional down to the version on CI.

greglook commented 4 years ago

Hmm, 2.9.2 has been out for a while, but I'm not keen on adding a version requirement just for this specific edge case. I think this can be closed for now and maybe revisited if/when leiningen 3.0.0 becomes a thing.

robhanlon22 commented 4 years ago

Sounds good. I'm sure that when/if it becomes a thing, everything is going to break anyway 🤷‍♀️

robhanlon22 commented 4 years ago

To be clear, this does work on lein 2.9, but with that extensive profile reading, it might degrade the performance of with-all.