search

amperity / vault-clj

Clojure client for Hashicorp's Vault secret management system.
Other
70 stars 17 forks source link

Fix #17, return 200 body upon write, cleaner patch off of master #19

Closed kenrestivo-stem closed 6 years ago

kenrestivo-stem commented 6 years ago

Wasn't sure if you were working off of master or develop. But if master is the right branch, here is the fix for #17

codecov-io commented 6 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@da8b05a). Click here to learn what that means. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #19   +/-   ##
========================================
  Coverage          ?   24.9%           
========================================
  Files             ?       6           
  Lines             ?     522           
  Branches          ?      15           
========================================
  Hits              ?     130           
  Misses            ?     377           
  Partials          ?      15
Impacted Files Coverage Δ
src/vault/client/http.clj 12.31% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da8b05a...59cffc8. Read the comment docs.

greglook commented 6 years ago

Change seems good, but please branch from and target the PR against develop. The master branch is only used for release versions.

kenrestivo-stem commented 6 years ago

OK, abandoning this, instead submitting https://github.com/amperity/vault-clj/pull/18