search

amperity / vault-clj

Clojure client for Hashicorp's Vault secret management system.
Other
70 stars 17 forks source link

consider expired, rotatable leases rotatable #42

Closed pyncc closed 4 years ago

pyncc commented 4 years ago

This helps mitigate secret expiration (outside the control of the client such as in a network outage) that would otherwise be rotatable. before this change, a lease wasn't marked 'renewable false' during the run of manage-leases so it would just be swept. instead, this at least attempts to rotate first before sweeping it for being expired.

codecov-io commented 4 years ago

Codecov Report

Merging #42 into develop will increase coverage by 2.19%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #42      +/-   ##
===========================================
+ Coverage    48.42%   50.62%   +2.19%     
===========================================
  Files           10       10              
  Lines          636      638       +2     
  Branches        30       29       -1     
===========================================
+ Hits           308      323      +15     
+ Misses         298      286      -12     
+ Partials        30       29       -1
Impacted Files Coverage Δ
src/vault/lease.clj 51.45% <100%> (+13.83%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update daffaeb...400e965. Read the comment docs.