alexparlett commented 3 years ago

To sanity check on this vault does expect the iam payload values to be b64 encoded, at the moment I have left that to the consumer to understand as I didn't want to pull additional dependencies into the project. Let me know if you think that is worth changing.

codecov-io commented 3 years ago

Codecov Report

Merging #50 (ef2b1a3) into master (eb9508d) will increase coverage by 1.61%. The diff coverage is 89.28%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   53.82%   55.44%   +1.61%     
==========================================
  Files          10       10              
  Lines         654      680      +26     
  Branches       28       29       +1     
==========================================
+ Hits          352      377      +25     
  Misses        274      274              
- Partials       28       29       +1

Impacted Files	Coverage Δ
src/vault/client/http.clj	`24.51% <0.00%> (ø)`
src/vault/core.clj	`83.33% <ø> (ø)`
src/vault/authenticate.clj	`57.14% <96.15%> (+12.83%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb9508d...ef2b1a3. Read the comment docs.

pyncc commented 3 years ago

https://github.com/amperity/vault-clj/releases/tag/1.0.2

amperity / vault-clj

Support aws IAM authentication #50

Codecov Report