Closed brendonjwong closed 1 year ago
:exclamation: No coverage uploaded for pull request base (
vault-2.x-rewrite@841ced8
). Click here to learn what that means. Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Implemented the GitHub auth's login method. This should resolve https://github.com/amperity/vault-clj/issues/79.
Validated with a local vault server and my personal Github token, using the Amperity organization. I figured it probably didn't make sense to have an integration test for this, but I'm open to ideas for how to durably test this.
Validation steps:
❯ vault write auth/test-mount/config organization=amperity Success! Data written to: auth/test-mount/config
❯ vault write auth/test-mount/map/teams/developers value=default Success! Data written to: auth/test-mount/map/teams/developers