search

amperity / vault-clj

Clojure client for Hashicorp's Vault secret management system.
Other
70 stars 17 forks source link

add approle login functionality #95

Closed beethan closed 1 year ago

beethan commented 1 year ago

This should add in support for the AppRole login function.

I based a majority of the changes off of stuff I saw in the other auth implementations.

With this, Issue #75 should be done. Once this has a ✅ I will go ahead and tackle one of the more complicated issues.

codecov-commenter commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (vault-2.x-rewrite@d229db2). Click here to learn what that means. Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## vault-2.x-rewrite #95 +/- ## ==================================================== Coverage ? 57.44% ==================================================== Files ? 19 Lines ? 1431 Branches ? 31 ==================================================== Hits ? 822 Misses ? 578 Partials ? 31 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amperity). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amperity)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

beethan commented 1 year ago

Do we want to implement any logic around bind_secret_id being disabled? It looks like if it is disabled a secret_id might not need to be provided.

I would think not to start but if it is a requested feature down the line we could add in support for it, but probably worth someone with more knowledge on AppRole chiming in.