codecov-commenter
commented
1 year ago Codecov Report
:exclamation: No coverage uploaded for pull request base (
vault-2.x-rewrite@59a96c3). Click here to learn what that means. Patch has no changes to coverable lines.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## vault-2.x-rewrite #96 +/- ## ==================================================== Coverage ? 58.40% ==================================================== Files ? 19 Lines ? 1464 Branches ? 31 ==================================================== Hits ? 855 Misses ? 578 Partials ? 31 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amperity). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=amperity):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
beethan
This is a follow up to #95
With this #75 might be complete.
This implements a few commonly used AppRole endpoints including
upsert-role!https://www.vaultproject.io/api-docs/auth/approle#create-update-approlelist-roleshttps://www.vaultproject.io/api-docs/auth/approle#list-rolesread-rolehttps://www.vaultproject.io/api-docs/auth/approle#read-approleread-role-idhttps://www.vaultproject.io/api-docs/auth/approle#read-approle-role-idgenerate-secret-id!https://www.vaultproject.io/api-docs/auth/approle#generate-new-secret-idI added a few additional tests, we may want to add a few more tests for these endpoints.