search

amperser / proselint

A linter for prose.
http://proselint.com
BSD 3-Clause "New" or "Revised" License
4.36k stars 179 forks source link

Useless dependency? #1352

Closed frenzymadness closed 7 months ago

frenzymadness commented 1 year ago

I see that this project depends on future:

https://github.com/amperser/proselint/blob/fe368030357a8300f383f9e906c08c73317d2021/pyproject.toml#L21

but I cannot find any real usage of this library here. Why do I care about it? future will no longer work with Python 3.12 because imp module has been removed from stdlib and the situation will be even worse with 3.13 because the lib2to3 which is the core of the future will be removed from stdlib as well.

Nytelife26 commented 1 year ago

You do not have to justify why you might care about the existence of a useless dependency. The importance of compatibility and a tidy bundle size cannot be overstated. To the best of my knowledge, this dependency is residual from prior Python 2 support.

I am unsure of the direction @suchow would take with this, but realistically the ecosystem has long surpassed the need to continue supporting Python 2, and I cleaned up the project to remove all need for future a while ago. I would be in favour of removing it.

Nytelife26 commented 7 months ago

Resolved passively in #1354.