amperser / proselint

A linter for prose.
http://proselint.com
BSD 3-Clause "New" or "Revised" License
4.31k stars 177 forks source link

ci: pin runner image versions #1368

Closed Nytelife26 closed 2 months ago

Nytelife26 commented 2 months ago

This relates to...

The key change here is using macos-12 instead of macos-latest. This prevents the runner from switching to arm64, for which there are no compiled versions of older Python targets (i.e. 3.8, 3.9).

orgua commented 1 month ago

but why also change ubuntu and windows? Going away from "latest" is only a workaround.

Nytelife26 commented 1 month ago

but why also change ubuntu and windows? Going away from "latest" is only a workaround.

in general version pinning so breaking changes are not administered automatically is a good way to run things. i will figure out a matrix that tests both, but in the meantime this is fine.

welcome back, by the way