ampervue / ngJWPlayer

Angular directives to instanciate a jwPlayer
MIT License
12 stars 6 forks source link

Error with Angular 1.5.8 #10

Closed parmarsanjay closed 7 years ago

parmarsanjay commented 7 years ago

I see following in my Bower.

├─┬ ng-jwplayer#0.2.2 │ └── angular#1.5.8 incompatible with ~1.4.2 (1.4.14 available, latest is 1.6.0-rc.1)

Is there a challenge running this directive with 1.5.8?

dkarchmer commented 7 years ago

No, it should work with 1.5.8. Need to update the dependency

parmarsanjay commented 7 years ago

Thanks @dkarchmer. Just tested it. I did work. I am not sure if bower is packaging 1.4.2 and 1.5.8 in my final distribution. I do have this in my bower.

"resolutions": { "angular": "1.5.8", "angular-cookies": "1.5.8" }