search

ampf / AMPF

Appscio Media Processing Framework
http://github.com/ampf/AMPF
4 stars 3 forks source link

'build-all' modifies system-level even when run without sudo #3

Closed wstidolph closed 14 years ago

wstidolph commented 14 years ago

This surprised me, maybe we should think about some mechanism to get acknowledgement that "this will write in system directories" before running:

I ran 'ant build-all' and it dumped files into /usr/local/lib/gstreamer (and so forth); this surprised me, since I'm expecting that only to happen if I run under 'sudo' ... it worked because my account is in the 'wheel' group which lets me run commands using 'sudo ...' without a password, but I didn't expect 'ant build-all' to attempt to write there (or to run using sudo somehow).

The more normal behaviour would be 'configure; make; sudo make install' for a system install, or 'configure --prefix=... ; make ; make install' for a local non-system installation.

gbowles commented 14 years ago

Ouch, that's definitely bad - again, are you using "ant build-all" ? That's supposed to call build-components.sh with the --no-install option, which is supposed to skip the "make install" step.

wstidolph commented 14 years ago

yep, just 'ant build-all'

simontuffs commented 14 years ago

antl build-all (or ant build-components) should invokes the build-components.sh script with --no-install, like it used to invoke the build-all script. Moreover, at this point we should cut out the extra install mechanism from that script, as I said in the other issue comment on this subject: that is legacy behavior and has no place in an RPM install driven process. In all the time I've been doing MPF builds, the only time I've used build-all without --no-install is by accident, and that has messed up my system. One of the reasons I wrapped it in ant with --no-install. Kill it. +5.

wstidolph commented 14 years ago

I'm not sure of what's going on with all this, but one comment: we should not tie our source buildability to a particular delivery packaging (RPM) - can I build this using autotools?

simontuffs commented 14 years ago

This has been fixed: it was caused by not having quotes on the argument to the build-components.sh script when using --noinstall. The fix has been multi-fold: make build-components not do --install by default, require --install to force an install, add --uninstall to let you clean up. Same has been done for GRDF.