search

amphibian-dev / toad

ESC Team's credit scorecard tools.
https://toad.readthedocs.io
MIT License
474 stars 173 forks source link

Combiner taking too much time to execute #131

Open FahadShahid143 opened 10 months ago

FahadShahid143 commented 10 months ago

Combiner takes too much time to execute. Below code takes several hours to execute. Is there a way to improve it?

combiner = toad.transform.Combiner() combiner.fit(X=x_train, y=x_train['label'], method='chi', min_samples = 0.05, exclude=exclude_list)

Secbone commented 9 months ago

@FahadShahid143 yes, it does only merge two values in a single step when using 'chi', it will take a long time when the unique value is too much, so I think if it can merge multiple values in a single step will improve the speed. I will work on it, and release the new version as soon as possible