amphibian / time_select.ee_addon

Fieldtype for ExpressionEngine® 2 and 3 that offers a configurable dropdown menu of times.
10 stars 3 forks source link

Deprecated warning in CP on PHP 8.0.24 #10

Open rowansentesy opened 2 years ago

rowansentesy commented 2 years ago

Hello,

One of our clients has your addon installed, and has been seeing Deprecated warnings. See attached file. cp-error-time-select (1)

I tracked it down to the function:

    function zenbu_display($entry_id, $channel_id, $data, $table_data = array(), $field_id, $settings, $rules = array())
    {
        $format = (isset($settings['setting'][$channel_id]['extra_options']['field_'.$field_id]['format'])) ? $settings['setting'][$channel_id]['extra_options']['field_'.$field_id]['format'] : '%g:%i%a';
        return (!empty($data)) ? ee()->localize->format_date($format, $data, FALSE) : '';

    }

This function, from what I can tell, is not in use on our client's site. It looks like this is specific to Zenbu addon which is not installed.

Let me know if you have a patch available for this, or if you plan on supporting PHP 8.x in the near future.

regards, Rowan

amphibian commented 2 years ago

This should be fixed in the latest release - test it out?