Replace `json-comments-rs` with `json5-rs`

amphitheatre-app / common

Rust libraries shared across Amphitheatre components and libraries.

Apache License 2.0

1 stars 3 forks source link

Replace `json-comments-rs` with `json5-rs` #20

Closed wangeguo closed 8 months ago

wangeguo commented 9 months ago

json-comments-rs is to support .devcontainer.json by stripping out the comments in JSON, I think json5-rs would be a bit better. for now we can try replacing it and keep the upper level interface intact to make sure that the current test case is 100% passable.

The refactoring will involve the following files:

Cargo.toml dependencies
src/devcontainer/de.rs

wangeguo commented 8 months ago

After careful research, json5-rs hasn't been updated in 2 years, and judging from feedback in Issues, performance is 50% slower than serde (not verified personally).