search

amphp / beanstalk

Asynchronous Beanstalk Client for PHP.
https://amphp.org/beanstalk/
MIT License
66 stars 24 forks source link

Wrong return type in bury promise #21

Closed mmenozzi closed 6 years ago

mmenozzi commented 6 years ago

Here: https://github.com/amphp/beanstalk/blob/a5128a053d7d46b74ac4ef7e8a44c8615dc5a3c8/src/BeanstalkClient.php#L192

The return type is int but the promise resolves with a bool value. Should be fixed but it would be a breaking change if someone is relying on a strict type check.

mmenozzi commented 6 years ago

Sorry this is already stated here: https://github.com/amphp/beanstalk/issues/13 Closing.