search

amphp / byte-stream

A non-blocking stream abstraction for PHP based on Amp.
https://amphp.org/byte-stream
MIT License
363 stars 31 forks source link

Add base64 streams and drop PHP 7.0 #73

Closed kelunik closed 4 years ago

kelunik commented 4 years ago

Seems like I already built something similar before: https://github.com/kelunik/streaming-base64

trowski commented 4 years ago

Should we put these in a sub-namespace like Amp\ByteStream\Base64?

kelunik commented 4 years ago

I don't really care, but sounds like a good idea.

kelunik commented 4 years ago

@trowski This should be ready now. I've dropped PHP 7.0 support due to : void being required on setUp on newer versions, but being unsupported on PHP 7.0. I've tried to use amphp/phpunit-util@1.4 with setUpAsync instead, but that requires PHP 7.1, too.