Improve LineReader with custom delimiters

amphp / byte-stream

A non-blocking stream abstraction for PHP based on Amp.

https://amphp.org/byte-stream

MIT License

363 stars 31 forks source link

Closed userqq closed 4 years ago

userqq commented 4 years ago

Please don't be angry for [$line, $this->buffer] thing, I will change it if you let me know. Just tried to simplify code a bit.

userqq commented 4 years ago

@kelunik Please see updated.

userqq commented 4 years ago

@kelunik Thank you for review!

kelunik commented 4 years ago

@userqq @hlib-kuznetsov Seems like committer and PR author account don't match, I hope that's fine.

hlib-kuznetsov commented 4 years ago

@kelunik Oh, sorry for confusing, it's both my accounts, i've created PR from this account by mistake.