amphp / dns

Async DNS resolution for PHP based on Amp.
https://amphp.org/dns
MIT License
157 stars 32 forks source link

Fixed Windows nameserver detection by only enumerating real NICs #114

Closed Bilge closed 8 months ago

Bilge commented 8 months ago

Previously we were enumerating every TCPIP interface regardless of disposition, including virtual NICs, bluetooth adapters, VPNs and disabled interfaces. It is most likely the case that valid nameserver configuration can only come from real, physical devices, which we now detect by enumerating the NetworkCards key first.

Ref: https://stackoverflow.com/q/6393373/1041515