search

amphp / dns

Async DNS resolution for PHP based on Amp.
https://amphp.org/dns
MIT License
157 stars 32 forks source link

Make implicit nullable types explicit #117

Closed nicolas-grekas closed 6 months ago

nicolas-grekas commented 7 months ago

Branch 1.x is the one we can use with Symfony HttpClient at the moment

Bilge commented 6 months ago

How is this an improvement?

bwoebi commented 6 months ago

@Bilge It will fix the deprecations of https://wiki.php.net/rfc/deprecate-implicitly-nullable-types in PHP 8.4.

bwoebi commented 6 months ago

@nicolas-grekas We sadly cannot trivially merge that into 1.x currently as the minimum supported version for the 1.x branch is 7.0, which doesn't know about nullable types.

I'm not sure what the best way forward here is.

Bilge commented 6 months ago

Just increase the minimum supported version. Doing so does not require a new major.

kelunik commented 6 months ago

@nicolas-grekas Thanks!

@bwoebi The way forward is quite obvious: Increase the minimum version to 7.1 as we did in most libraries already, e.g. amphp/socket.