search

amphp / dns

Async DNS resolution for PHP based on Amp.
https://amphp.org/dns
MIT License
157 stars 32 forks source link

Cache composer dependecies for faster builds #31

Closed staabm closed 8 years ago

mention-bot commented 8 years ago

By analyzing the blame information on this pull request, we identified @rdlowrey, @Danack and @bwoebi to be potential reviewers

bwoebi commented 8 years ago

Could you please explain how this takes effect? Comparing build time of the PR on travis, I see no difference to older builds?

kelunik commented 8 years ago

Because the cache is not yet there, it's the first commit.

kelunik commented 8 years ago

Thanks!

staabm commented 8 years ago

@bwoebi this PR does not yet benefit from the build cache, only commits after this one will.

the benefit is, that composer packages wont get downloaded over http but instead will be re-used from previous builds (local hdd vs. remote request).

kelunik commented 8 years ago

This commit won't anyway, because it's a separate branch and has it's own cache.