search

amphp / dns

Async DNS resolution for PHP based on Amp.
https://amphp.org/dns
MIT License
157 stars 32 forks source link

Make windows-registry optional #54

Closed assertchris closed 7 years ago

assertchris commented 7 years ago

Currently, amphp/windows-registry requires a version of amphp/process which makes installing amphp/aerys ^0.4.5 alongside amphp/parallel ^0.1.0@dev impossible. This change makes amphp/windows-registry an optional (suggested) dependency, which can be installed in the event the app needs to run on a Windows machine.

I have no idea how popular amphp/dns is with Windows users, but I imagine it's far more useful for amphp/parallel to work alongside amphp/aerys. This should become less of a problem as the libraries stabilise around Amp 2.0...

mention-bot commented 7 years ago

@assertchris, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rdlowrey, @kelunik and @DaveRandom to be potential reviewers.

kelunik commented 7 years ago

No, this won't work. It is absolutely required, making it an optional dependency doesn't make sense. DNS is used everywhere, as it's a dependency of amphp/socket.

Aerys 0.4.5 is Amp v1, while Parallel is Amp v2. The issue you see is because those conflict. Just use the amp_v2 branch of Aerys.